zulip / python-zulip-api

Python library for the Zulip API.
https://zulip.com/api/
Apache License 2.0
350 stars 356 forks source link

ci: Setup Github Actions for Windows. #662

Closed ganpa3 closed 3 years ago

ganpa3 commented 3 years ago

As requested

timabbott commented 3 years ago

@ganpa3 this looks pretty good; if we can arrange to duplicate less code, that'd be great, but maybe it's hard with the hardcoded paths.

ganpa3 commented 3 years ago

@timabbott @neiljp I have refactored the changes. Please have a look again.

timabbott commented 3 years ago

I'm going to go ahead and merge this so that we can start seeing the CI run, but @ganpa3 please still test whether we can remove the python above and rely on shebang lines.

ganpa3 commented 3 years ago

@timabbott I tested running without shebangs, but the script doesn't run. Shebang support is specific to py launcher on Windows (More info).

timabbott commented 3 years ago

OK, great, thanks for the confirmation!