search

zulip / python-zulip-api

Python library for the Zulip API.
https://zulip.com/api/
Apache License 2.0
350 stars 356 forks source link

Coverage is incorrectly reported as 0% on README.md #670

Closed timabbott closed 2 years ago

timabbott commented 3 years ago

This is likely a side effect of the CircleCI => GitHub migration.

https://app.codecov.io/gh/zulip/python-zulip-api seems to not be 0, so I'm guessing we just have the badge misconfigured.

Ponni-M commented 3 years ago

@zulipbot claim

zulipbot commented 3 years ago

Hello @Ponni-M!

Thanks for your interest in Zulip! You have attempted to claim an issue without the labels "help wanted", "good first issue". Since you're a new contributor, you can only claim and submit pull requests for issues with the help wanted or good first issue labels.

If this is your first time here, we recommend reading our guide for new contributors before getting started.

Ponni-M commented 3 years ago

@zulipbot add "good first issue"

Ponni-M commented 3 years ago

@zulipbot claim

zulipbot commented 3 years ago

Welcome to Zulip, @Ponni-M! We just sent you an invite to collaborate on this repository at https://github.com/zulip/python-zulip-api/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip!

Here's some tips to get you off to a good start:

As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site.

See you on the other side (that is, the pull request side)!

Ponni-M commented 3 years ago

@timabbott I have added the gist action to my fork, we may need to add the gist access token to this project. You can also refer in my branch if the changes are fixing the issue https://github.com/Ponni-M/python-zulip-api/tree/Ponni-M-patch-1

harshakhmk commented 3 years ago

@zulipbot claim

zulipbot commented 3 years ago

Welcome to Zulip, @harshakhmk! We just sent you an invite to collaborate on this repository at https://github.com/zulip/python-zulip-api/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip!

Here's some tips to get you off to a good start:

As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site.

See you on the other side (that is, the pull request side)!

harshakhmk commented 3 years ago

I think the badge is correctly configured in README but it is somehow related to this correct me if I am wrong

zulipbot commented 3 years ago

Hello @harshakhmk, you claimed this issue to work on it, but this issue and any referenced pull requests haven't been updated for 10 days. Are you still working on this issue?

If so, please update this issue by leaving a comment on this issue to let me know that you're still working on it. Otherwise, I'll automatically remove you from this issue in 4 days.

If you've decided to work on something else, simply comment @zulipbot abandon so that someone else can claim it and continue from where you left off.

Thank you for your valuable contributions to Zulip!

andersk commented 3 years ago

https://app.codecov.io/gh/zulip/python-zulip-api seems to not be 0,

But it has no data since 2020-12-02. The GitHub Actions output indicates that it only finds one “coverage report” at ./zulip-api-py3-venv/bin/coverage-3.9, which is not a coverage report.

gvarun1 commented 3 years ago

@zulipbot claim

zulipbot commented 3 years ago

Welcome to Zulip, @gvarun1! We just sent you an invite to collaborate on this repository at https://github.com/zulip/python-zulip-api/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip!

Here's some tips to get you off to a good start:

As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site.

See you on the other side (that is, the pull request side)!

gvarun1 commented 3 years ago

@zulipbot abandon

pradeepcep commented 3 years ago

I checked the badge with both codecov's and shield's images. It seems like only the master branch is affected for now, but the badges say "unknown" intermittently.

Examples:

I don't think it's a badge config issue either. It looks like the coverage report is missing from the Github action altogether. In other branches, a ./coverage.xml seems to be generated, but in master branch, it wasn't.

One more difference is this line in the output: In master:

Python coveragepy not found

In codecov:

Python coveragepy exists disable via -X coveragepy
    -> Running coverage xml

I'll pull the repo in the near future and try to see if I can find anything else.

pradeepcep commented 3 years ago

@zulipbot claim

zulipbot commented 3 years ago

Welcome to Zulip, @pradeepcep! We just sent you an invite to collaborate on this repository at https://github.com/zulip/python-zulip-api/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip!

Here's some tips to get you off to a good start:

As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site.

See you on the other side (that is, the pull request side)!

pradeepcep commented 3 years ago

@zulipbot claim

pradeepcep commented 3 years ago

Second time's the charm. Here we go!

pradyumn014 commented 2 years ago

@timabbott Looks like the issue isn't there anymore - Screenshot from 2021-09-29 10-44-06

andersk commented 2 years ago

I fixed this in #699.