Adding fetch_upload method to client

zulip / python-zulip-api

Python library for the Zulip API.

https://zulip.com/api/

Apache License 2.0

350 stars 352 forks source link

Adding fetch_upload method to client #678

Open Ponni-M opened 3 years ago

Ponni-M commented 3 years ago

https://github.com/zulip/python-zulip-api/issues/628

timabbott commented 3 years ago

@Ponni-M can you restructure the commits to first refactor the /api/ prefix stuff, with a commit message explaining why that's correct, and then one adding the new endpoint?

Check out the Zulip commit message guidelines for more details: https://zulip.readthedocs.io/en/latest/contributing/version-control.html#commit-messages

LoopThrough-i-j commented 3 years ago

@Ponni-M thanks for working on this, added a comment. Everything else LGTM.

zulipbot commented 2 years ago

Heads up @Ponni-M, we just merged some commits that conflict with the changes your made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the upstream/main branch and resolve your pull request's merge conflicts accordingly.