search

zulip / python-zulip-api

Python library for the Zulip API.
https://zulip.com/api/
Apache License 2.0
350 stars 352 forks source link

zulip: Replace GET realm/filters with realm/linkifiers. #681

Closed abhijeetbodas2001 closed 3 years ago

abhijeetbodas2001 commented 3 years ago

In zulip/zulip@3947b0c80a26b9126540ada996f027aac03063b7, we replaced the legacy endpoint to use the term "linkifier" instead of "filter" and to return the data in a dictionary format.

None of the official clients currently actually use this endpoint.

abhijeetbodas2001 commented 3 years ago

Do I need to do anything for backwards compatibility? I changed the name of the function here, so it could break any existing application which uses that function. But not changing would break it too, because the data returned would be different than what the client expected.

timabbott commented 3 years ago

If we wanted to be fancy, what we'd do for backwards compatibility would be to have the client connect process do a GET /server_settings to verify the Zulip server when you initialize the client, and check the feature_level for which endpoint to call, etc.

I think given this endpoint's low use level and the fact that we haven't yet built said infrastructure, we can just merge this; folks can always run an old version of python-zulip-api as needed.