zulip / python-zulip-api

Python library for the Zulip API.
https://zulip.com/api/
Apache License 2.0
350 stars 352 forks source link

zulip: Add tests for API functions. #682

Open LoopThrough-i-j opened 3 years ago

LoopThrough-i-j commented 3 years ago

I was thinking of simulating an event queue for testing call_on_each_event but restricted myself from doing that thinking of the previous comments and from the prospects of setting up an integration test suite.

LoopThrough-i-j commented 3 years ago

@timabbott a review on this if possible would be great.

LoopThrough-i-j commented 3 years ago

@timabbott thanks for the review I will update the PR shortly, with required comments and explanations as best as I can.

zulipbot commented 1 year ago

Heads up @LoopThrough-i-j, we just merged some commits that conflict with the changes you made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the upstream/main branch and resolve your pull request's merge conflicts accordingly.