zulip / python-zulip-api

Python library for the Zulip API.
https://zulip.com/api/
Apache License 2.0
355 stars 358 forks source link

zulip: Standardize the names of bindings with OperationIDs. #712

Open MSurfer20 opened 3 years ago

MSurfer20 commented 3 years ago

I have manually audited, and these are all the bindings whose names don't match the operationIDs as defined in zulip.yaml.

timabbott commented 3 years ago

Thanks for doing this audit @MSurfer20! I started https://chat.zulip.org/#narrow/stream/378-api-design/topic/python.20bindings.20function.20names/near/1255079 for discussion.

timabbott commented 2 years ago

This looks great; rebasing to get CI to run in case the new automated tests of the server implementation fail with the new deprecation warning logging output. I think we need to do one thing before merging:

Once that happens, we can merge this and our TODO to finish this cleanup process will be:

@MSurfer20 can you let @eeshangarg know when you expect to get to the examples/ work? If it'll be a while, then we might want to just do a 0.8.2 release to fix #732 without waiting for this.

zulipbot commented 2 years ago

Heads up @MSurfer20, we just merged some commits that conflict with the changes your made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the upstream/main branch and resolve your pull request's merge conflicts accordingly.