Slack bridge: Explicitly require aiohttp.

zulip / python-zulip-api

Python library for the Zulip API.

https://zulip.com/api/

Apache License 2.0

355 stars 358 forks source link

Slack bridge: Explicitly require aiohttp. #722

Closed rht closed 3 years ago

rht commented 3 years ago

It is required by the Slack library, but strangely not installed. So we explicitly specify it.

timabbott commented 3 years ago

Merged, thanks @rht!

andersk commented 3 years ago

This was already fixed upstream (slackapi/python-slack-sdk#1000), why don’t we upgrade instead?

timabbott commented 2 years ago

Good point; we should do so. Realistically probably we should upgrade all the Python dependencies while we're at it. @PIG208 @eeshangarg @rht do any of you have time for this?

eeshangarg commented 2 years ago

@timabbott Currently swamped with projects, added to my list for when my plate clears up a bit!

rht commented 2 years ago

@timabbott I upgraded the Slack dependency: #730. I have to also upgrade the RTM client API to v2 because otherwise it still requires aiohttp.