api: Add subset of Literal types used in zulip-terminal

zulip / python-zulip-api

Python library for the Zulip API.

https://zulip.com/api/

Apache License 2.0

350 stars 352 forks source link

api: Add subset of Literal types used in zulip-terminal #737

Closed neiljp closed 2 years ago

neiljp commented 2 years ago

See https://chat.zulip.org/#narrow/stream/378-api-design/topic/python.20bindings.20and.20constants

The first commit is useful as it integrates with the API directly; the second doesn't integrate with the API as the method parameter data types are unspecified dicts right now (see discussion).

neiljp commented 2 years ago

As per the discussion in #api design, this is now updated and ready for review.

It looks like we'll squash commits when this is done, so I just dropped the new comment updates in a separate commit for now.

neiljp commented 2 years ago

@gnprice Thanks for feedback; pushed an update.

timabbott commented 2 years ago

Merged after a bit of copy-editing, huge thanks for doing this @neiljp!