search

zulip / python-zulip-api

Python library for the Zulip API.
https://zulip.com/api/
Apache License 2.0
350 stars 352 forks source link

Slack bridge: Implement multiple channels bridges. #739

Closed rht closed 1 year ago

rht commented 1 year ago

@PIG208 thank you for the review!

rht commented 1 year ago

I have implemented the requests in the 3rd commit.

rht commented 1 year ago

I have implemented the requests and tidied the commits.

neiljp commented 1 year ago

@rht I'm not sure how much detail is expected here before merging, but other than the checks above (one needing fixing - static-analysis), has this been tested and if so how?

rht commented 1 year ago

The static analysis test has been fixed.

has this been tested and if so how?

I tested this on a live Slack workspace and CZO. I have retested just now, just in case if the refactor causes any regression. See https://chat.zulip.org/#narrow/stream/7-test-here/topic/.3C-.20slack-bridge.20general and https://chat.zulip.org/#narrow/stream/7-test-here/topic/.3C-.20slack-bridge.20general

timabbott commented 1 year ago

Merged, thanks @rht!