Closed eeshangarg closed 2 years ago
Hmm.. there might be more to the story here. The thing I noticed is that my WSL2 installation has pip 9.0.1
which is greater than pip 9.0
which is what we checked for before, but pip 9.0.1
is still outdated. So we need to prevent the outcome where a virtual environment ends up with pip 9.0.1
.
We don’t need the latest version; we just need to bump >=9.0
to >=10
, because pip 10 was the first release to support PEP 518.
@andersk Thanks a lot for the review!
The version of pip that comes bundled with venv is often outdated, which can lead to unexpected errors when installing dependencies. This commit ensures that pip is upgraded to the latest version before any dependencies are installed.
This commit fixes an issue I discovered in my WSL2 development environment. Before this commit, running
python3 tools/provision
resulted in the following exception:After some investigation, I discovered that the
pip
was not being upgraded properly.@andersk Could you please review this?