zulip / python-zulip-api

Python library for the Zulip API.
https://zulip.com/api/
Apache License 2.0
355 stars 357 forks source link

Cert Bundle might also be a directory #748

Open e7p opened 2 years ago

e7p commented 2 years ago

When using the requests API with the certificate parameter, it is also possible to enter e.g. /etc/ssl/certs as a certificate bundle and it will result in verifying against all certificates lying in this path.

Though, I would recommend also including os.path.isdir() in the statement.

https://github.com/zulip/python-zulip-api/blob/e6dff1b5b6a9c6851d6c6699c2c52f345a4f486e/zulip/zulip/__init__.py#L492

e7p commented 2 years ago

Can be linked to #749