zulip / python-zulip-api

Python library for the Zulip API.
https://zulip.com/api/
Apache License 2.0
350 stars 352 forks source link

Matrix bridge: Print reminder to subscribe the bots on startup. #756

Closed rht closed 1 year ago

rht commented 2 years ago

This problem has happened far too frequently. See e.g. https://chat.zulip.org/#narrow/stream/9-issues/topic/.E2.9C.94.20Matrix.20Zulip.20integration.20error/near/1388040.

dehnert commented 2 years ago

From the README, it sounds like configuring the room and stream is required. Would it make sense to grab subscriptions from Matrix (if possible) and Zulip and ensure the expected room+stream are present? Or even do the subscription in the code? (Not sure if that'd really be desirable.)

An unconditional warning still seems maybe useful, but warning only when the config seems wrong is probably more useful (at least sometimes I'd expect people to think they've subscribed, but not actually done so).

rht commented 2 years ago

723 already does the auto-subscription. I'm deciding not to spend more time into the existing Matrix bridge because it is going to be replaced by #723 anyway.

From the README, it sounds like configuring the room and stream is required

But looks like people still miss the description.

timabbott commented 1 year ago

Merging this, since it seems like a useful stopgap pending #723 being completed. (And it's probably not worth spending a bunch of time making the error handling details here nicer given that plan).