integrations: Enhanced matrix bridge. (Fix #723)

zulip / python-zulip-api

Python library for the Zulip API.

https://zulip.com/api/

Apache License 2.0

350 stars 352 forks source link

integrations: Enhanced matrix bridge. (Fix #723) #765

Closed ro-i closed 1 year ago

ro-i commented 1 year ago

Hi :) This PR aims to fix #723 for Windows. As discussed there, python-magic seems to be problematic on Windows. However, I noticed in the output of the CI that python-magic-bin doesn't get installed as requested. (It's needed to provide the Windows library support as described here). Thus, my first attempt to fix the Windows support is trying to get python-magic-bin properly installed. If this doesn't work, I disable the magic-support in Windows completely.

ro-i commented 1 year ago

Ok, this does not seem to work. Unfortunately without useful error message in the logs :/ So I'll completely disable python-magic on Windows...

ro-i commented 1 year ago

The Windows tests now succeed, just the code coverage is not yet happy...

rht commented 1 year ago

Can you highlight the change you made that makes it work on Windows? I couldn't spot any difference. The requirements.txt looks the same.

rht commented 1 year ago

Strange. The coverage should have been identical to https://github.com/zulip/python-zulip-api/pull/723/commits/12b5e7a2507bcac9c6b6db794158c03ef7ff7173.

timabbott commented 1 year ago

Merged, thanks @ro-i!