zulip / python-zulip-api

Python library for the Zulip API.
https://zulip.com/api/
Apache License 2.0
355 stars 357 forks source link

matrix bridge: Improve mime-type detection. #766

Closed ro-i closed 2 years ago

ro-i commented 2 years ago

Hi :) This PR lets the matrix bridge handle mime-types of files without the python-magic library by using the response object of the HTTP request. See here for the discussion. Please review :)

rht commented 2 years ago

The code LGTM. Probably just needs a live bridge test for confirmation, which I assume you have done so?

ro-i commented 2 years ago

Yeah, I did some manual testing with a few files :)

timabbott commented 2 years ago

Merged, thanks @ro-i and @rht!