search

zulip / python-zulip-api

Python library for the Zulip API.
https://zulip.com/api/
Apache License 2.0
350 stars 352 forks source link

Do not send heartbeat events to clients. #781

Closed showell closed 1 year ago

showell commented 1 year ago

I tested this with https://github.com/showell/zulip-api-examples/blob/main/heartbeat_bug.py.

See https://chat.zulip.org/#narrow/stream/137-feedback/topic/api.20client.20silent.20failure for more context.

timabbott commented 1 year ago

I took care of the comment above, added some explanatory code comments, and pushed the changes back here.