IRC: Add option for SASL authentication.

zulip / python-zulip-api

Python library for the Zulip API.

https://zulip.com/api/

Apache License 2.0

355 stars 357 forks source link

Closed rht closed 10 months ago

rht commented 1 year ago

This reverts to using sync IRC client, because upstream https://github.com/jaraco/irc only supports it for the sync client.

rht commented 1 year ago

cc: @asdf8dfafjk

timabbott commented 10 months ago

Looks good, but looks like it has a merge conflict. @andersk feel free to rebase and merge if it helps you upgrade dependencies.

rht commented 10 months ago

Rebased.

andersk commented 10 months ago

What’s the motivation here? Adding SASL support sounds good, but dropping non-SASL support sounds limiting?

rht commented 10 months ago

I will add back the PLAIN authentication, so as not to restrict user's choice.

rht commented 10 months ago

Rebased and the SASL authentication is now optional.

andersk commented 10 months ago

Merged without the error handling change since that needs more work and should arguably be separate anyway. Feel free to open a new PR for it.