zulip / python-zulip-api

Python library for the Zulip API.
https://zulip.com/api/
Apache License 2.0
350 stars 352 forks source link

api: Add get_stream_email_address(). #817

Closed rsashank closed 2 weeks ago

rsashank commented 6 months ago

Python wrapper function for the new endpoint introduced in ZFL 226 to fetch a stream's email address. This could enhance the ease of making calls within zulip terminal and potentially other clients.

neiljp commented 6 months ago

@timabbott LGTM based on manual test, and given lack of old-server fallbacks and inconsistent nearby styling to compare to (see below).

It would be good to get this out, unless more API calls would be beneficial to add based on new changes/features in 7.5+/8.0?

It looks like we don't note/handle lack of features in older servers in zulip, ie. on an older server this call would simply fail with this call - the only use of feature_level is for method parameters, not the presence of the feature.

Reviewing adjacent code, we're not particularly consistent with style:

timabbott commented 2 weeks ago

Merged, thanks @rsashank!