search

zulip / zulip-desktop

Zulip Desktop client for Mac, Windows and Linux.
https://zulip.com/apps
Apache License 2.0
844 stars 424 forks source link

Settings: improved visibility of text and buttons #1367

Open Aitchessbee opened 5 months ago

Aitchessbee commented 5 months ago

What's this PR do? Improves text and button visibility in settings page as reported in #1357

Screenshots? Old: image

New: image

You have tested this PR on:

timabbott commented 5 months ago

Can you present before/after screenshots? Also, I'm not sure which component is the settings_description part.

Aitchessbee commented 5 months ago

Update the description with old and new images... settings_description is a class given to the text in each row. It was already present in the code but wasn't used in css.

timabbott commented 5 months ago

OK. Text definitely feels a lot better. The dark grey slider background might be overdoing it a bit; is there somewhere a bit in between worth trying?

alya commented 5 months ago

Maybe, but overall this is a definite improvement.

Axshatt commented 2 months ago

OK. Text definitely feels a lot better. The dark grey slider background might be overdoing it a bit; is there somewhere a bit in between worth trying?

I think the tab headings should also be in dark colour as it will be a good user experience