zulip / zulip-desktop

Zulip Desktop client for Mac, Windows and Linux.
https://zulip.com/apps
Apache License 2.0
857 stars 434 forks source link

improvement: Windows taskbar icon notification like Skype #167

Closed penCsharpener closed 7 years ago

penCsharpener commented 7 years ago

In windows the sys tray icon is too often hidden at the moment, and the number of unread msgs is tiny.

The legacy had this wonderful number in the taskbar icon. Please add this also in Electron app because in a multi-monitor setup we miss a lot of message due to this.

Lplenka commented 7 years ago

The features of our app will be limited to the capabilities of the upstream electron. There is no support to show unread count in the taskbar (also not in the tray) in the upstream electron for now. We have added the functionality to show unread count in the tray.

Since you are facing the problem with the size of the tray icon. We have to show unread count in the taskbar. Looking for possible ways :sweat_smile: .

penCsharpener commented 7 years ago

Would it be worth submitting a request issue in the electron repository? What version of electron is zulip app using right now? Maybe the feature is there in electron but not the version zulip is built on.

there are more limitations with having notifications just in the tray: on a multi-monitor setup the tray is not duplicated to secondary screen even if your settings say that you want the taskbar duplicated. ie. I use three screen most of the time ...

Lplenka commented 7 years ago

@vbNETonIce feel free to open issues there. I also created this issue https://github.com/electron/electron/issues/9020

Currently we are using 1.6.8 version of electron. yes we are behind. There were some newer verions released a couple of days ago.

timabbott commented 7 years ago

This is probably worth doing some nontrivial investment in creating, after we've fixed the more critical bugs we're aware of.

ElliotSilver commented 7 years ago

The linked electron issue indicates other apps are generating icons on the fly, which, in the absence of an actual API, seems like a reasonable solution.

This is the primary issue that has been holding me back from switching from the old desktop app to the electron one.

I usually have ~20 or so applications in the task bar, and minimal icons displayed in the notification area (so that I can see all 20 applications). I could show the Zulip icon in the notification area, but I'm already giving Zulip space in the taskbar, so I'd much rather it use that space.

timabbott commented 7 years ago

Increasing the priority on this, since it sounds like it's a blocker to migrating for a number of people.

penCsharpener commented 7 years ago

Thanks Tim, we basically forced everyone to use the electron app but we had many long faces when they didn't have the taskbar notifications anymore from the legacy app. And with multi-monitor setups many still complain about missing msgs. If this can be done it would be a major step forward!

penCsharpener commented 7 years ago

for future reference some electron messengers that have taskbar notifications: inofficial whatsapp claims to have it: https://github.com/bcalik/Whatsapp-Desktop official wire: https://github.com/wireapp/wire-desktop (although I have to check it again.

but electron also has some documentation about overlaying the taskbar icon overlay icon with image

flashing the taskbar icon with only few lines of code this could be easy to implement, wouldn't it?

so it looks like Electron is supporting those notifications. 😃

akashnimare commented 7 years ago

@vbNETonIce thanks for above links. I'll look into it :)

akashnimare commented 7 years ago

This feature has been added in https://github.com/zulip/zulip-electron/commit/67dc1e2a11ab7b573776ccaa90656b8051e57124. This is how it looks - pasted_image 2

@vbNETonIce, @ElliotSilver can you verify if it works properly.

penCsharpener commented 7 years ago

you nailed it! Looking great and it's eye catching. Well, I guess it was a few more lines of code than my 3, haha. flash and overlay

akashnimare commented 7 years ago

@vbNETonIce Thanks, I told you it's just a matter of time. @ElliotSilver feel free to migrate to zulip-electron :)