zulip / zulip-desktop

Zulip Desktop client for Mac, Windows and Linux.
https://zulip.com/apps
Apache License 2.0
840 stars 422 forks source link

Add "badge" with # of streams with messages #305

Open ewoutkramer opened 6 years ago

ewoutkramer commented 6 years ago

In my workflow, I have disabled desktop notifications since we have some high-volume streams. Of course, this means I do not know whether anything new has come in. When I close the desktop app main window, I would love for the tray icon to show whether any new messages have come in in the same way Skype works: show a number with the number of streams with unread messages.

(this is on Windows 10 by the way)

timabbott commented 6 years ago

I can see something like this being useful for some workflows. If we wanted to make that work, we'd need to expose the data from the webapp codebase to the Electron app; it's all there, so shouldn't be hard, but will require some plumbing.

That said, I'm curious: @ewoutkramer have you thought about muting the high-traffic streams?

ewoutkramer commented 6 years ago

If I understand your suggestion correctly, I should mute all high-traffic streams and re-enable desktop notifications. That's an improvement - but it won't help me if I was away from the desktop and a message came in. It would actually improve the features: if you would just count the number of non-muted streams with new messages for display in the badge, I would be totally happy.

Discussing this, I realize my problem is really this: I have some high-traffic streams that I monitor periodically - so I really open up zulip to read them now and then. But there are others that I'd like to react on as quickly as possible. I could now divide these two groups by muting all streams except the "urgent" ones - the badge count would tell me that something happened in the urgent streams, even if I missed the desktop notification

akashnimare commented 6 years ago

@ewoutkramer we have taskbar icon and system tray icon which shows the no. of unread messages even if you disable desktop notification.

image

image

Also, there is a "Flash Taskbar on new message" setting which flashes the taskbar icon on an incoming message.

I'm not sure what else we should add here 😕

ewoutkramer commented 6 years ago

My number of unread messages is practically always 99+ - caused by a few streams that have a huge amount of traffic. These are not the most important streams to watch however and I read them periodically, but it means that the message count is useless for me and the "new message" setting would not help me either.

Now, a suggestion was to simply mute these high-traffic streams. This is certainly an option.

Now that I have more experience with the client, I think I know what I would like: to be able to have the message count show just the count for the streams that I pinned to "top". I could leave the streams that I watch now and then below - not influencing my message count, and be able to decide for myself which streams were important enough to keep bugging me about! Maybe I would even re-enable desktop notifications again if these were limited to my favorite ones on top!

akashnimare commented 6 years ago

@ewoutkramer if this is your situation then I'm sure the unread count will be useless even if it only shows the no. of unread message count of the top pinned stream (since as you mentioned those streams have heavy traffic i.e. always 99+) 😄

to be able to have the message count show just the count for the streams that I pinned to "top"

This is not possible with the desktop app and for this, we need to make changes in the web-app. For now, the best option is -

That way you'll only get the notifications from important streams. Although the badge count will still show the unread count of all unmuted streams.

priyank-p commented 6 years ago

I might look into this, i think we can use preload script and detect unread count per stream and we can provide setting to display count for specific stream i think but i am not sure.

(Thankfully zulip had already done work, so we don't have to in most cases like Notifications)

akashnimare commented 6 years ago

Yeah, that option is available though not sure how feasible it would be as we'll need to fetch the unread counts every now and then (like every 5 sec or so from pinned streams).

ewoutkramer commented 6 years ago

Thanks for looking into this, guys! I know it won't bring world peace, but would improve my workflow. I'll selectively re-enable notifications for my "top" streams as suggested above.

akashnimare commented 5 years ago

@timabbott this is fixed in https://github.com/zulip/zulip/pull/12677, right?

ewoutkramer commented 5 years ago

If I understand it correctly, #12677 would restrict the count to private msgs/mentions, not the pinned channels. Anyway, that's an improvement that I would certainly use!