search

zulip / zulip-desktop

Zulip Desktop client for Mac, Windows and Linux.
https://zulip.com/apps
Apache License 2.0
849 stars 429 forks source link

Add a feature to configure DND mode #561

Open akashnimare opened 6 years ago

akashnimare commented 6 years ago

We have a basic DND feature in the left sidebar which activates the DND mode and to deactivate user need to update it manually. It would be great to have something like -

and then automatically handles the notification setting after the DND time gets over.

Two things we need to do here - a) UI/UX - I think we can show the time within the tooltip itself b) How to calculate the DND time since there could be multiple cases like the laptop is switched off/sleep etc.

image

priyank-p commented 6 years ago

To implement this I have/had a rough plan in mind:

For step two, we can use something like node-schedule to do turn off the DND button after the specified time, in which case if the app is closed or device shut-down it will not work. Which we will need to cover in step three.

lukasIO commented 6 years ago

I know this is the repository for the electron app, but can you clarify why you see DND as an app setting rather than a profile-setting? Imho it leads to confusion and unwanted behaviour if there is a DND layer above a profile setting. If I don't want to be disturbed, then I do so in my online status which should then reflect across all apps.

similarly if i want to receive notifications again, I should be able to do so on mobile and the changes should reflect on desktop. that's why I think this should be followed further (only) as a profile setting and not as an app setting.

akashnimare commented 6 years ago

@lukasIO please see the relevant conversations here - https://chat.zulip.org/#narrow/stream/16-desktop/topic/DND.20button

lukasIO commented 6 years ago

Thanks for the link. As it seems the main reasonis this statement by @timabbott

I think it's actually probably useful to have a desktop app feature for this, because if you're in multiple organizations, you kida want to be able to turn it off for all of them at once.

I agree that this is a very good point, which i didn't consider before. I would still prefer if this kind of status-change would reflect consistently over web, desktop and mobile. How to communicate over multiple organizations a common state - I have no idea. An approach to change an additonal notification-status in each logged in organization would be an option, maybe.

akashnimare commented 6 years ago

For the webapp - https://github.com/zulip/zulip/issues/295

akashnimare commented 6 years ago

For the UI thing, we could show something like this in the tooltip -

image

manavmehta commented 4 years ago

@zulipbot claim

zulipbot commented 4 years ago

Welcome to Zulip, @manavmehta! We just sent you an invite to collaborate on this repository at https://github.com/zulip/zulip-desktop/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip!

Here's some tips to get you off to a good start:

As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site.

See you on the other side (that is, the pull request side)!

zulipbot commented 4 years ago

Hello @manavmehta, you have been unassigned from this issue because you have not updated this issue or any referenced pull requests for over 14 days.

You can reclaim this issue or claim any other issue by commenting @zulipbot claim on that issue.

Thanks for your contributions, and hope to see you again soon!

manavmehta commented 4 years ago

@zulipbot PR #896 has been made and is under review

varun-s22 commented 1 year ago

Is this still open? because on my machine i am unable to produce the time, as you have done in your PR(s) @akashnimare @manavmehta

VANSH3104 commented 1 month ago

@zulipbot claim

zulipbot commented 1 month ago

Welcome to Zulip, @VANSH3104! We just sent you an invite to collaborate on this repository at https://github.com/zulip/zulip-desktop/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip!

Here's some tips to get you off to a good start:

As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site.

See you on the other side (that is, the pull request side)!