Broken image icon in left sidebar

zulip / zulip-desktop

Zulip Desktop client for Mac, Windows and Linux.

https://zulip.com/apps

Apache License 2.0

847 stars 429 forks source link

Broken image icon in left sidebar #562

Open akashnimare opened 6 years ago

akashnimare commented 6 years ago

This happens when the app can't find the realm icon and it shows the broken image for few secs. As a fallback, we're using the character icon from the realm name but it shows up after the broken image icon. We could do better here.

Possible solutions - a) Change the way we show the realm icon in the left sidebar. We could first show the character icon on app load and then lazy load the relam icons (if they exist).

b) Replace the broken image icon with something nice - https://bitsofco.de/styling-broken-images/

To reproduce this delete the icon key from the domain.json.

ThePiyushGupta commented 5 years ago

@zulipbot claim

zulipbot commented 5 years ago

Welcome to Zulip, @ThePiyushGupta! We just sent you an invite to collaborate on this repository at https://github.com/zulip/zulip-electron/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip!

Here's some tips to get you off to a good start:

Join me on the Zulip developers' server, to get help, chat about this issue, and meet the other developers.
Sign the Dropbox Contributor License Agreement, so that Zulip can use your code.
Unwatch this repository, so that you don't get 100 emails a day.

As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site.

See you on the other side (that is, the pull request side)!

ThePiyushGupta commented 5 years ago

@zulipbot abandon

isunitha98selvan commented 5 years ago

@zulipbot claim

zulipbot commented 5 years ago

Hello @isunitha98selvan, it looks like you've currently claimed 1 issue in this repository. We encourage new contributors to focus their efforts on at most 1 issue at a time, so please complete your work on your other claimed issues before trying to claim this issue again.

We look forward to your valuable contributions!

ThePiyushGupta commented 5 years ago

@akashnimare This issue seems to be specific to your os or machine as I am unable to reproduce it after multiple tries. The charachter Icon from the realm name appers Instanty without any delay.However it shows the fallback charachter until the application is restarted. Even with multiple servers it i am unable to reproduce the error .However the only problem is is that it shows the fallback charachter until the app is restarted

Nikhil-Vats commented 5 years ago

@zulipbot claim

zulipbot commented 5 years ago

Hello @NikhilPhalange, you have been unassigned from this issue because you have not updated this issue or any referenced pull requests for over 14 days.

You can reclaim this issue or claim any other issue by commenting @zulipbot claim on that issue.

Thanks for your contributions, and hope to see you again soon!

Nikhil-Vats commented 5 years ago

@zulipbot Yes, I have a pending Pull request which needs to be accepted. I have completed the work.

vsvipul commented 5 years ago

@zulipbot claim

vsvipul commented 5 years ago

@zulipbot abandon