search

zulip / zulip-desktop

Zulip Desktop client for Mac, Windows and Linux.
https://zulip.com/apps
Apache License 2.0
855 stars 435 forks source link

System tray icon ugly in KDE Plasma #620

Open xeruf opened 5 years ago

xeruf commented 5 years ago

The icon in the system tray in KDE Plasma has no borders separating the content from the remainder of the system tray, and as soon as there is more than 9 new messages, you can barely see the number.

abhigyank commented 5 years ago

This is a known upstream issue. Description and temporary solution described here vector-im/riot-web/issues/6767 comment . Most electron apps seems to be effected by this on KDE. The fix has been made to chromium and soon should be in electron in its upcoming releases. Two possible temporary solutions -

xeruf commented 5 years ago

Ok. Just so you know, the way you linked to the comment did not work, but I found it anyway ;)

abhigyank commented 5 years ago

Sorry my bad. Thanks for letting know. Edited. Let us know if the fixes work for you.

xeruf commented 5 years ago

Adding XDG_CURRENT_DESKTOP=Unity to the application starter indeed worked, while libappindicator made absolutely no difference.

timabbott commented 5 years ago

Is the XDG_CURRENT_DESKTOP thing a workaround we can do for everyone, or will it cause problems for folks using other windowing systems?

xeruf commented 5 years ago

Shouldn't be a problem, since it is just an application parameter. You could even include it in the .desktop starter until the issue is resolved

devurandom commented 4 years ago

I see this in my systray when Zulip has unread messages: Screenshot_20191128_023723 Is that the same bug, or shall I open a separate report?

Fedora 31, KDE Plasma 5.16.5, KDE Frameworks 5.61.0, Qt 5.12.5.

akashnimare commented 4 years ago

@devurandom the image is too small. Can you please post another screenshot/gif etc?

fdcds commented 4 years ago

@akashnimare The icon is very small on the screen too, so no idea how to enlargen it...

It shows a white rectangle with rounded corners, with the bottom right corner cut off. In the middle of the rectangle is a grey triangle with an white exclamation mark in the middle.

akashnimare commented 4 years ago

Hmm, looks like it's broken for some reasons.

devurandom commented 4 years ago

I also had a look with my Gentoo Linux machine with KDE Plasma 5.17.3, KDE Frameworks 5.64.0, Qt 5.13.2 and the issue is the same.

timabbott commented 4 years ago

Is it possible we're just not registering the icon in the right way for KDE?

akashnimare commented 4 years ago

I don't have the KDE so it's hard to debug the root cause but as far as I know, this could be the platform-limitation from electron's side. They usually don't cover all the distros. For example, the badge api only works in Ubuntu 16+( with unity launcher).

fdcds commented 4 years ago

The Zulip logo displays fine as long as Zulip has no internet connection. Once it has a connection, the logo changes to the one described in https://github.com/zulip/zulip-desktop/issues/620#issuecomment-559307696 and https://github.com/zulip/zulip-desktop/issues/620#issuecomment-559482623. I assume it is related to when it displays the unread message count.

A little bit confusing: I remember that at some point I actually saw the Zulip logo with a small "99+" in the systray at some point. But on none of my machines I get that right now.

devurandom commented 4 years ago

The Zulip logo displays fine as long as Zulip has no internet connection. Once it has a connection, the logo changes to the one described in #620 (comment) and #620 (comment). I assume it is related to when it displays the unread message count.

Correction: Disabling "Show app unread badge" in the settings has no impact.

A little bit confusing: I remember that at some point I actually saw the Zulip logo with a small "99+" in the systray at some point. But on none of my machines I get that right now.

Addition: When I disable "Show app icon in system tray" and then re-enable it, I get a green circle with "99+" inside. This is independent of the "Show app unread badge" setting.