zulip / zulip-flutter

Upcoming Zulip mobile apps for Android and iOS, using Flutter
Apache License 2.0
197 stars 192 forks source link

deps: Upgrade Flutter to 3.27.0-1.0.pre.166 #1018

Closed PIG208 closed 1 month ago

PIG208 commented 1 month ago

And update Flutter's supporting libraries to match.

Built successfully on my Android device; still need to confirm that it works on IOS. This contains a major version bump to the dart SDK (changelog).

3.7.0 adds Wildcard Variables, that we currently doesn't seem to use.

There is also changes to the Dart to Javascript Compiler (dart2js) and Dart Development Compiler (dartdevc), both are "switched to use an AOT snapshot instead of a JIT snapshot". Neither of them applies to us because we do not use the web builds.

chrisbobbe commented 1 month ago

still need to confirm that it works on IOS.

Yup, just tested on an iOS simulator and it works there too. Thanks; LGTM! Marking for Greg's review.

gnprice commented 1 month ago

Thanks for taking care of this! Looks good; merging.

The Dart version bump is from 3.6.0-etc to 3.7.0-etc, so I'd call that a minor-version bump; the major version is just 3.

We definitely don't yet use wildcard variables, because as the changelog says:

Dart 3.7 adds wildcard variables to the language. To use them, set your package's SDK constraint lower bound to 3.7 or greater (sdk: '^3.7.0').

they only become allowed once you bump the Dart version bound in your pubspec to at least 3.7.0, as this PR does :slightly_smiling_face: