zulip / zulip-flutter

Upcoming Zulip mobile apps for Android and iOS, using Flutter
Apache License 2.0
176 stars 164 forks source link

msglist: Spoilers should always grow downward when they open #536

Open chrisbobbe opened 7 months ago

chrisbobbe commented 7 months ago

With #503, we'll have support for spoilers! It has a glitch that won't be straightforward to fix, though, so I'm filing this to be worked on later.

The message list's growth direction is up, not down. As a result, when you open a spoiler, it grows up, but it would be better if it grew down, in the direction of the "expand" arrow. Here's what #503 looks like:

Feb-26-2024 14-36-29

It's possible that we'll eventually build the message list out of two back-to-back slivers, with opposite growth directions, instead of just one sliver that grows upward. This approach is being considered for a few issues:

If that happens, then I guess spoilers might sometimes naturally grow downward, but only if they happened to be in the sliver that grows downward.

Puneet2504 commented 7 months ago

Hi @gnprice can you assign me this issue

gnprice commented 7 months ago

@Puneet2504 Please take a look at our guide for picking an issue to work on: https://github.com/zulip/zulip-flutter#picking-an-issue-to-work-on

This isn't an issue that's likely to be a good one for anyone's first few contributions to Zulip.

gnprice commented 5 months ago

Reported in chat: https://chat.zulip.org#narrow/stream/48-mobile/topic/flutter.20spoilers.20pin.20scroll.20at.20bottom/near/1799494