search

zulip / zulip-flutter

Upcoming Zulip mobile apps for Android and iOS, using Flutter
Apache License 2.0
189 stars 178 forks source link

tools/check: `pigeon` runs old/cached version of Pigeon after Pigeon dependency is upgraded #622

Open chrisbobbe opened 7 months ago

chrisbobbe commented 7 months ago

Part of #621 was to upgrade Pigeon, from 17.2.0 to 18.0.0. After I did that, tools/check pigeon --all-files on my machine was running the old Pigeon, while in CI the newer Pigeon was running, as we want it to, and flagging the need to update generated files. I found a workaround: https://github.com/zulip/zulip-flutter/pull/621#issuecomment-2040764190 but it would be nice not to require a manual step.

Can we make it so when we change the version of the Pigeon dependency, the next run of tools/check pigeon --all-files uses the updated version?

gnprice commented 5 months ago

To make the workaround explicit in this thread: it's that after an upgrade affecting package:pigeon, and before running tools/check pigeon, one runs dart run pigeon.

That just prints the pigeon CLI's help message… but first it causes the pigeon CLI binary itself to get rebuilt with the new package.