zulip / zulip-flutter

Future Zulip client using Flutter
Apache License 2.0
143 stars 117 forks source link

content: Highlight non-silent mentions of the self-user #647

Open chrisbobbe opened 2 months ago

chrisbobbe commented 2 months ago

This probably makes sense to do after #646.

We should highlight non-silent mentions of the self-user, following web, so that users can easily see when a mention is intended to get their attention.

For some examples (and here I'm logged in as the "Chris Bobbe" account):

image image

Notice the highlighting is done in two ways:

chrisbobbe commented 2 months ago

(Should we add this to #309?)

gnprice commented 2 months ago

Thanks. Yeah, like #646, this is part of #157.

I think rather than add to #309, we can just rely on the a-content label and the milestones.

alya commented 2 months ago

In case it's helpful, note the unsubscribed channel edge case: https://github.com/zulip/zulip/pull/27765.

chrisbobbe commented 2 months ago

The web app also colors the background of the message's corresponding date separator (if any):

image

We should probably follow web.