Use new null-safe generics in Pigeon

zulip / zulip-flutter

Future Zulip client using Flutter

Apache License 2.0

164 stars 139 forks source link

Use new null-safe generics in Pigeon #942

Open gnprice opened 2 weeks ago

gnprice commented 2 weeks ago

The Pigeon feature request to handle types like List<Foo>, as opposed to only List<Foo?>, is complete:

https://github.com/flutter/flutter/issues/97848#event-14254355682

We have a couple of types in our pigeon/notifications.dart that could benefit from that. One has a TODO comment; for the full list, look for List< and Map<.

ArpanMondalGITHUB commented 2 weeks ago

Can I work on it

skylon07 commented 6 days ago

I also noticed that the docs should probably be updated too, since #5 is now obsolete.

gnprice commented 1 day ago

@skylon07 Good catch, yeah.

That'd be a good point to make as an issue in the Flutter upstream tracker: https://github.com/flutter/flutter/issues . This thread here is in the issue tracker of a particular app that uses Flutter, namely Zulip.

skylon07 commented 1 day ago

Oh, haha, I clicked into this issue from the Flutter repo and didn't realize I had switched to Zulip. My apologies -- I'll make a ticket there instead.