search

zulip / zulip-flutter

Upcoming Zulip mobile apps for Android and iOS, using Flutter
Apache License 2.0
196 stars 191 forks source link

Tweak dark theme for slightly higher contrast #973

Open gnprice opened 1 month ago

gnprice commented 1 month ago

Our colors in dark theme are based on those in web. The dark theme in web is getting adjusted to have slightly higher contrast, and we should follow. Details:

For mobile, the specific design from @terpimost can be found here: https://www.figma.com/design/1JTNtYo9memgW7vV6d0ygq/Zulip-Mobile?node-id=4514-33396&t=bMNXsr5LwkrHz4dp-1

@terpimost would you suggest using the exact same values for these in mobile as in web? Or would you prefer to update things in the mobile Figma doc?

Related (but independent) PR

IfeanyiSam commented 1 month ago

Is this issue open to work on? I want to work on this issue if it is open

donnywellson commented 1 month ago

@zulipbot claim

donnywellson commented 1 month ago

I would like to be assigned this issue. I have already started by grouping the theme files and makeing the ZulipTheme easier to read and understand

gnprice commented 1 month ago

I've just updated the issue description with the design freshly provided by @terpimost, so it's possible now to work on this issue.

outdated replies

@donnywellson assigning to you; please go ahead. I'm not sure we'll want to merge rearrangements to the theme code; but as long as you keep them in separate commits, following our style for [clean and coherent commits](https://zulip.readthedocs.io/en/latest/contributing/commit-discipline.html), that won't get in the way of reviewing your main changes. @IfeanyiSam please take a look at our guide for claiming an issue: https://zulip.readthedocs.io/en/latest/contributing/contributing.html#in-other-zulip-repositories