search

zulip / zulip-flutter

Upcoming Zulip mobile apps for Android and iOS, using Flutter
Apache License 2.0
197 stars 192 forks source link

actions test: Await all responses; cut pumpAndSettle #993

Closed gnprice closed 1 month ago

gnprice commented 1 month ago

This ensures that if one of these markNarrowAsRead calls were to change behavior so that it no longer completed within the test (and then possibly threw an error, or failed to ever complete at all), the test would catch that.

Prompted by this thread: https://github.com/zulip/zulip-flutter/pull/934#discussion_r1796319431

PIG208 commented 1 month ago

Looks good! Just one small comment.

gnprice commented 1 month ago

Thanks for the review! Merging with that tweak.