Closed rajveermalviya closed 1 month ago
Well, just as I was putting this PR up, it looks like the ubuntu-latest == ubuntu-24.04
rollout is being rolled back:
https://github.com/actions/runner-images/issues/10636#issuecomment-2417303444
fun 😄
Well, just as I was putting this PR up, it looks like the
ubuntu-latest == ubuntu-24.04
rollout is being rolled back: actions/runner-images#10636 (comment)fun 😄
Oh, I was wondering why some test suddenly failed on the pipeline when I sent in my PR.
Thanks @rajveermalviya for sorting this out! I'd run into the same issue yesterday at https://github.com/zulip/zulip-flutter/pull/998#issuecomment-2415545081 but hadn't yet spent time to investigate.
This seems like a good change even if for the moment it's no longer needed. How about combining it with a change to use ubuntu-24.04
specifically? That way CI would validate for us that the change fully solves the problem.
Thanks for the review @gnprice! I've updated the commit to also change the checks' runner image to use ubuntu-24.04
explicitly. PTAL.
Thanks! Looks good; merging.
I tweaked the commit message, mainly here:
- As a result, five unit tests now fail with the following error:
+ Without that package, five unit tests would fail with the following
+ error:
because (since GitHub rolled back the change of ubuntu-latest
to 24.04) there's no longer a "now" when the unit tests actually do fail; rather it's a hypothetical, that if we just bumped the version without adding this setup step, those tests would fail.
The
package:sqlite3
requires the system-installed sqlite3 shared library (libsqlite3.so
) when running directly via Dart, on Linux. Whereas, when running under Flutter, it uses bundled libraries provided bypackage:sqlite3_flutter_libs
.Recently, the
ubuntu-latest
runner image has switched to defaulting toubuntu-24.04
: https://github.com/actions/runner-images/issues/10636 Previously, it usedubuntu-22.04
, which had thelibsqlite3-dev
package pre-installed: https://github.com/actions/runner-images/blob/main/images/ubuntu/Ubuntu2204-Readme.md#installed-apt-packages However, theubuntu-24.04
image no longer includes this package by default: https://github.com/actions/runner-images/blob/main/images/ubuntu/Ubuntu2404-Readme.md#installed-apt-packagesAs a result, five unit tests now fail with the following error:
To resolve these test failures, add a step to manually install the
libsqlite3-dev
package.