search

zulip / zulip-mobile

Zulip mobile apps for Android and iOS.
https://zulip.com/apps/
Apache License 2.0
1.3k stars 655 forks source link

Android: sometimes screen does not stretch completely #3068

Open borisyankov opened 6 years ago

borisyankov commented 6 years ago

An issue was reported that on certain Android phones we do not stretch the app vertically:

The concrete device is Xiaomi Poco F1, which has a notch on top.

Possible cause - the notch on top might need some special handling.

Another possible cause - our use of https://github.com/miyabi/react-native-safe-area might somehow be incorrect on Android (though the component does handle Android by returning zeroes for offset values which should be the correct behavior)

gnprice commented 5 years ago

(See also #3066 about the handling of safe area vs. notch on iOS, and #3067 which will switch to RN's SafeAreaView instead of that react-native-safe-area library.)