Open jainkuniya opened 5 years ago
Demo can be tested here: https://github.com/jainkuniya/zulip-mobile/tree/issue-3352
Related but separate issue: we should be showing a higher resolution avatar in AccountDetails
.
Would you look into that too?
By Higher resolution
you mean the url with -medium.png
?
On Tue, Feb 19, 2019, 4:27 PM Boris Yankov <notifications@github.com wrote:
Related but separate issue: we should be showing a higher resolution avatar in AccountDetails. Would you look into that too?
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/zulip/zulip-mobile/issues/3352#issuecomment-465085108, or mute the thread https://github.com/notifications/unsubscribe-auth/ARp1SXdVtaa02LUeGJaQNedz8izQ7pL9ks5vO9iHgaJpZM4bCBl7 .
Yeah. I am not sure if we should be using medium
there or at all.
I don't remember the details, worked on these too long ago.
Also, it is totally possible that the original decision was not correct :)
All I know is that often when looking at the AccountDetailsScreen
the avatar looks blurry from the lower-than-ideal resolution we are using.
All I know is that often when looking at the
AccountDetailsScreen
the avatar looks blurry from the lower-than-ideal resolution we are using.
Currently we are showing image with
getMediumAvatar
as url. But on slow internet connections it takes time to load image and in this time nothing is shown, empty screen. Which doesn't look good. So till image is completely loaded, show a thumbnail image i.e the avatar which we usually show in message list. Also add a smooth transition between real image and the thumbnail image, like https://medium.com/react-native-training/progressive-image-loading-in-react-native-e7a01827feb7@zulipbot claim