search

zulip / zulip-mobile

Zulip mobile apps for Android and iOS.
https://zulip.com/apps/
Apache License 2.0
1.3k stars 654 forks source link

Align longPress menu theme to match night mode theme #3402

Open schezfaz opened 5 years ago

schezfaz commented 5 years ago

Currently, the longPress menu does not comply with the night mode theme. Aligning the themes would enahnce the night mode user experience!!

Screenshot_2019-03-12-09-59-51-372_com zulipmobile debug

schezfaz commented 5 years ago

@zulipbot claim

pulkonet commented 5 years ago

@schezfaz Hi, please let me know if you're not working on it I would very much like to take this forward.

jainkuniya commented 5 years ago

Actually this is not straight forward, we are using 3 party library react-native-action-sheet. We need to do changes in it. Anyway soon we will be having in house action sheet, so we can take care this in that our own component. :)

schezfaz commented 5 years ago

Oh, no wonder. For the last 3 days I was trying to figure out how allButtonsRaw, showActionSheet and showActionSheetWithOptions get invoked and where they get styled. Makes sense now!

We could incooperate this change when we put the in-house action sheet into development. Also, similiar changes (aligning the theme to match night-mode) needs to be done for the options menu for images as well (while in night mode).

I would definitely like to work on migrating from react-native-action-sheet to the zulip action sheet!!

Screenshot_2019-03-17-14-30-28-451_com zulipmobile debug