search

zulip / zulip-mobile

Zulip mobile apps for Android and iOS.
https://zulip.com/apps/
Apache License 2.0
1.27k stars 640 forks source link

Permanently unsendable messages are shown with spinners #3731

Open rk-for-zulip opened 4 years ago

rk-for-zulip commented 4 years ago

If sending a message fails with a 4xx error (indicating that retrying won't help), the message still appears in the message list with a spinner, rather than some form of failure UI.

rk-for-zulip commented 4 years ago

One reproduction method here (until #3743 is fixed) is to send a message with an empty or whitespace-only topic.

rk-for-zulip commented 4 years ago

From offline brainstorming: perhaps there should be an optional httpResponse field in Outbox. Items with 4xx codes should be displayed as an :x:; other messages get the spinner.

We could also give httpResponse a special non-numeric "too old to send" value (see discussion on #3734) and retain messages that would have been dropped due to age, instead displaying them with an :x: as well.

gnprice commented 4 years ago

With the potential feature described in zulip/zulip#13626, this case may start arising more often.

chrisbobbe commented 4 years ago

We've had another report of this, at https://github.com/zulip/zulip-mobile/issues/4033#issuecomment-613743082.