Open gnprice opened 2 years ago
Can I work on this?
I have created a PR please look into it
i can change that icon can you assign me on this
Hi, I'd like to help out on this issue.
@dootMaster great! Please post a comment describing your proposed approach when you're ready. We can assign the issue to you once you have a rough plan. Thanks!
@alya
The goal is to change the icon of mobile Zulip's All Messages tab to be congruent with the icon that currently exists in the browser Zulip app.
HomeScreen.js
contains a button component titled TopTabButton
.TopTabButton
accepts a string property name
that is passed into another component titled Icon
.Icon
component is sourced from Icons.js
, a script that contains numerous functions that help build icons from the react-native-vector-icons
package dependency.Rough plan:
First, I will read the docs: Contributing, and Style Guide.
name
passed in the TopTabButton
component such that when it is consumed by the Icon
function in Icons.js
, an icon that is congruent to the "list" icon that currently exists on the browser Zulip app is returned.chat.zulip.org
.Sounds good, thanks, @dootMaster! I've just assigned this issue to you.
I've created a draft pull request. I'll also post this in the code review stream on the chat.
edit: tag for visibility @chrisbobbe
I want to work on this issue, please assign it to me
Sure, I see the current PR #5471 has been awaiting a revision from the author for some time, but it looks like we have a proposed implementation; see https://github.com/zulip/zulip-mobile/pull/5471#issuecomment-1230861599. You can try doing that.
Hi, things got a little busy for me. The revision is done; I've created a PR awaiting review.
@dootMaster What's the right PR to look at? #5458? (I guess GitHub incorrectly show it as merged?)
@alya #M5532. Yeah, GitHub is incorrectly showing the other as merged.
I checked the app, we still have this issue. I want to work on this.
I think the next step here is for maintainers to re-review #5532.
@alya Is it resolved?
We currently use a "globe" icon for the button on the main screen that takes you to the all-messages view. This has never been a great icon to use there, but we didn't feel we had a better one -- the web app used a "home" icon, and that seemed like it would put too much emphasis on that view. (Unlike on web, the all-messages view has never been the main view that we present.)
But now web uses a "list" icon:
That seems perfectly reasonable, and it's helpful to have the same icon on web as on mobile. So let's switch to that one.
(From chat thread here.)