jefferypalmer
commented
1 year ago Open jefferypalmer opened 1 year ago
jefferypalmer
commented
1 year ago jefferypalmer
commented
1 year ago Stack trace posted above, might be an underlying library update, but unsure where to start looking. Any hints?
chrisbobbe
commented
1 year ago Thanks for the report, and for taking the time to provide that stacktrace! That sounds like a very frustrating issue.
This looks like an error that has affected React Native apps for years: https://github.com/facebook/react-native/issues/17530. React Native is the framework used to build zulip-mobile, the current Zulip mobile apps. It looks like a purported fix was actually merged in React Native quite recently: https://github.com/facebook/react-native/commit/98789e9da646e889632aaf14af4f39841c79ea10. That change doesn't appear in any React Native releases yet, but I assume it will soon if it doesn't get reverted.
As a workaround, does it help if you uninstall and reinstall the app?
Realistically, with the effort required to upgrade to new React Native versions as they come out, our most likely path to a permanent fix is to develop and release the new Zulip mobile apps built in Flutter.
chrisbobbe
commented
1 year ago Linking an old discussion of a same-looking error: https://chat.zulip.org/#narrow/stream/243-mobile-team/topic/RN.2067.3A.20add.20to.20styles.2Exml.3F/near/1395349
jefferypalmer
commented
1 year ago @chrisbobbe understood, both efforts are substantial. It makes sense to put that coding time into flutter if that's the path forward vs the myriad of react upgrades required to get from .68 to .72.
I did a complete erase of the app, delete cache, delete storage, and reinstall, and the crash remains the same.
gnprice
commented
1 year ago I did a complete erase of the app, delete cache, delete storage, and reinstall, and the crash remains the same.
Dang. Thanks for the update (and the original report).
We'll keep an eye on this issue. If we hear more reports of it as the Android 14 beta progresses, so that it sounds like it's widely affecting Android 14 users, then we may have to take further action on it.
Depending on how early Google sends Android 14 to general release (likely either August or September, based on history), we may have zulip-flutter to beta stage by then. In that case I think the recommendation for anyone who's enough of an early adopter to jump straight on the new OS release will be to use the zulip-flutter beta :slightly_smiling_face:
If this issue affects a wide range of React Native apps on Android 14, then there might also be further developments upstream that give us more options for fixing it — for example the fix might get backported to older release series.
For anyone else seeing this issue, please chime in here to help us gauge how widespread it is. In the meantime, the best workaround will be to open Zulip in your mobile device's web browser.
jefferypalmer
commented
1 year ago @gnprice while thinking about flutter, there are a few other features missing from the zulip mobile client such as unread badge counts on iOS and Android. Is there a good place in the flutter dev repo to post these?
chrisbobbe
commented
1 year ago Indeed! Our tracker for that project is https://github.com/zulip/zulip-flutter/issues, and it's accepting new issues.
When filing an issue there, it would be helpful to check a few things first, to minimize its chance of being closed:
zulip-flutter than in zulip-mobile, and it may already be done. This will become easier to check during the public beta period, of course, but in the meantime you can send a quick question in #mobile or #mobile-team in the Zulip development community.zulip-flutter tracking the feature already? (For example, badge counts on iOS is open as zulip/zulip-flutter#153.)zulip-mobile tracking the feature? We have a plan to sweep through the zulip-mobile issues, opening zulip-flutter issues for points that also apply there.chrisbobbe
commented
1 year ago gnprice
commented
11 months ago @darren1713 reports that the crashes stopped upon upgrading to v27.213, where we disable Sentry: https://github.com/zulip/zulip-mobile/issues/5766#issuecomment-1741143191
That suggests that these had the same cause as #5757, related to Sentry. Details of that issue here: https://github.com/zulip/zulip-mobile/issues/5757#issuecomment-1728692990
Closing this issue because it appears that disabling Sentry resolved it. We have an open issue #5757 for re-enabling Sentry in our JavaScript and Kotlin code, but with its native code kept inactive, which should avoid the crashes it was causing. When we do that, I'll definitely be interested in hearing whether the crashing remains fixed for @darren1713, as well as for the folks in the #5757 thread; I'll update when we have a build to try out. Thanks again @darren1713 for the report and the updates!
chrisbobbe
commented
11 months ago Recording for the thread (though of course I'm glad that v27.213 seems to have fixed these crashes!):
I think we've been getting events with this issue's error output much more frequently on Android versions other than 14, than on Android 14. And in both cases, the frequency graph doesn't have the ominous-uptick shape that was characteristic of the crashes that became the focus of #5757.
gnprice
commented
11 months ago Hmm I see, thanks for pointing that out.
Looking at numbers for these crashes, I'm a bit puzzled now, but in any case it no longer seems like v27.213 fixed these crashes in general (even though they apparently did so for @darren1713). So I'll reopen.
Specifically, in the data Google Play gives us, we've been seeing this crash just as often on v27.213 as we did on older versions. Our total number of crashes has gone way down — way back down, to where it was before #5757 emerged, after being elevated for a couple of weeks. But this one is unchanged.
Puzzlingly, though, in the Google Play data I see zero crash reports from Android 14 that have anything like this stack trace. There's plenty of reports from Android 14 that look like #5757 — so it's not like Android 14 isn't reporting data for some reason — but none for this issue. (Those data only go back 60 days, so don't cover when @darren1713 saw the crash posted at https://github.com/zulip/zulip-mobile/issues/5741#issuecomment-1607952269 ; though it's also possible his device isn't reporting crashes to Google Play.)
So, maybe Android 14 somehow fixed this? (*) We'll get a better idea once it rolls out to a general release… err, which I guess just happened today, so we'll get a better idea very soon as people upgrade and we start having a much larger share of our users on it.
() Which would be extra odd given that for @darren1713 it seemed to be the Android 14 upgrade that caused it to start* regularly happening.
jefferypalmer
commented
11 months ago @gnprice Great details there. Some quick behavior notes on my Android 14 experience, I'm on Pixel 5, running Android beta, and have gone through Android 14 beta releases UP1, UP2, UP3, and currently on UP4, with all of them exhibiting the same crash in 30 seconds or less behavior and grabbed the log that opened this ticket. The update to UP4 was about 6 weeks ago, crashes remained, and then 2 weeks ago the crashed stopped out of the blue, so I went to investigate. Found the zulip app had a new release, so dug into changelog and what might be the connection. I don't have any other relevant data so technically it could be something else that was patched in the latest release quite honestly, but wanted to point this out as an item to investigate before re-enabling sentry. PS: Glad to test any builds you want to check for this error on Android 14.
gnprice
commented
11 months ago @darren1713 Thanks for those further details!
We just today posted a v27.214 release to beta; it re-enables Sentry, but leaving the native side disabled (i.e. it does #5766). In our own testing that continues to prevent the crashes, just like v27.213 did by disabling Sentry completely, but I'd definitely be interested in hearing how it works for you too. If you're not already on the beta channel, see here to join.
gnprice
commented
11 months ago We've now sent v27.216 to all users. As discussed at #5778, it turned out that this:
We just today posted a v27.214 release to beta; it re-enables Sentry, but leaving the native side disabled (i.e. it does #5766). In our own testing that continues to prevent the crashes, just like v27.213 did by disabling Sentry completely
did not hold when we got wider testing from our beta users, so for v27.216 we went back to disabling Sentry entirely (on Android) like v27.213 did.
@darren1713 I'll be curious to hear whether you've seen the "crash in 30 seconds or less" symptoms on v27.216, or whether you do after upgrading if you haven't yet.
Android 14 is causing near instant crashes when the app is opened, and restarts to try again, causing restart loops. Sometimes it will remain open just long enough to type one message and then crash on send or crash while simply looking at the app. There doesn't seem to be any inherent connection between actions in the app and when it is crashing so I suspect it has something to do with the background server communications. This issue only appeared after updating to Android 14 and have never experienced this issue before. Have tried both zulip beta and zulip release versions with no success.
Any hints or pointers?
Thanks