search

zulip / zulip-mobile

Zulip mobile apps for Android and iOS.
https://zulip.com/apps/
Apache License 2.0
1.29k stars 654 forks source link

No avatars on mobile when forcing default-avatar.png in local-static #5797

Open lurendrejer opened 11 months ago

lurendrejer commented 11 months ago

After disabling users ability to change avatars, gravatar sync and setting default avatar in settings.py - the mobile app displays an '?' for every users avatar.

Only tested on iPhones atm.

lurendrejer commented 11 months ago

The avatar is displayed properly at the 'top' of the conversation, but fails inside the conversation.

IMG_0631

gnprice commented 11 months ago

Interesting, thanks for the report.

The fact that it works in the app bar at the top of the screen, and doesn't work inside the message list, seems very informative as a clue. I suspect the issue is that the server isn't recognizing the authentication credentials the client sends for accessing the image, because the way we do that is different between those two places.

Specifically, inside the message list, we provide the credential by adding it to the URL as a query parameter. The server accepts this only on certain routes — it accepts it on user-uploaded files, for example. What's needed is for it to accept that form of authentication for this custom default avatar as well — otherwise that feature of a custom default avatar won't fully work, as you see here.

What's the name of the setting you're using for this in settings.py?

lurendrejer commented 11 months ago

Hi.

These are the lines i have changed in settings.py AVATAR_CHANGES_DISABLED = True ENABLE_GRAVATAR = False DEFAULT_AVATAR_URI = "/local-static/default-avatar.png"

gnprice commented 8 months ago

Thanks for the reply — sorry I missed this in my inbox earlier.

If my suspected diagnosis above is right, then this is an issue that's fixed by our upcoming new app, written in Flutter. The Flutter app reached beta in December: https://chat.zulip.org/#narrow/stream/2-general/topic/Flutter/near/1708728

So one debugging step that would be helpful is for you to try out that beta and see if the issue goes away. If so, that'd confirm the diagnosis; if it doesn't, we can debug further.

lurendrejer commented 8 months ago

Tested in flutter beta - the issue is gone on iOS.

Den 4. mar. 2024 kl. 23.34 skrev Greg Price @.***>:



Thanks for the reply — sorry I missed this in my inbox earlier.

If my suspected diagnosis above is right, then this is an issue that's fixed by our upcoming new app, written in Flutter. The Flutter app reached beta in December: https://chat.zulip.org/#narrow/stream/2-general/topic/Flutter/near/1708728

So one debugging step that would be helpful is for you to try out that beta and see if the issue goes away. If so, that'd confirm the diagnosis; if it doesn't, we can debug further.

— Reply to this email directly, view it on GitHubhttps://github.com/zulip/zulip-mobile/issues/5797#issuecomment-1977586432, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AHL5PIFZEQ77D3ZGMX3CRJTYWTZIXAVCNFSM6AAAAAA7YW7YIOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNZXGU4DMNBTGI. You are receiving this because you authored the thread.Message ID: @.***>

gnprice commented 8 months ago

Great. Glad to hear it, and thanks for confirming.

Because this app is in maintenance mode as we're focused on building the new app, I think this is a bug we won't get to fixing in this legacy codebase. Instead it'll effectively be fixed by the migration to the new app.