api types: Make external_authentication_methods required; present since 2.1 - Githubissues

zulip / zulip-mobile

Zulip mobile apps for Android and iOS.

https://zulip.com/apps/

Apache License 2.0

1.3k stars 656 forks source link

api types: Make external_authentication_methods required; present since 2.1 #5815

Closed chrisbobbe closed 10 months ago

chrisbobbe commented 10 months ago

And simplify downstream.

My goal with this simplification, once we decide that it's valid, is to make the code easier to read for clues about what's necessary for zulip/zulip-flutter#36. This stuff about authentication_methods is confusing—how it's marked as deprecated, yet still necessary for correct clients. See discussion linked in a code comment; here's that same link: https://chat.zulip.org/#narrow/stream/412-api-documentation/topic/audit.20for.20change.20entries.20vs.2E.20central.20changelog/near/1404115

gnprice commented 10 months ago

Thanks for the cleanup! LGTM; merging.