search

zulip / zulip-mobile

Zulip mobile apps for Android and iOS.
https://zulip.com/apps/
Apache License 2.0
1.3k stars 656 forks source link

deps: Run `yarn upgrade`, toward addressing Apple "privacy manifest" issue #5850

Closed chrisbobbe closed 7 months ago

chrisbobbe commented 7 months ago

Related: #5847

Stacked atop #5848 which allows testing on iOS with recent Xcode.

Manually smoke-tested on the office Android device and my iPhone.

gnprice commented 7 months ago

Cool, thanks for taking care of this.

Glad this gets us the latest Sentry in particular — that seems like one SDK that is probably using some of these APIs and so will need a privacy manifest (and has hopefully added one by now :crossed_fingers: — we'll find out as you pursue #5847 further).

[…] In particular, after the app starts up
on Android, I get errors:

  Error: Requiring module
    "node_modules/react-native-screens/src/index.tsx", which threw an
    exception: Error: Exception in HostObject::get(propName:RNSModule):
    java.lang.UnsatisfiedLinkError:
    dalvik.system.PathClassLoader[DexPathList[[zip file "/data/app/com.zulipmobile.debug-cCKhUjMGcecB6tGNtf5jiQ==/base.apk"],nativeLibraryDirectories=[/data/app/com.zulipmobile.debug-cCKhUjMGcecB6tGNtf5jiQ==/lib/arm64, /data/app/com.zulipmobile.debug-cCKhUjMGcecB6tGNtf5jiQ==/base.apk!/lib/arm64-v8a, /system/lib64]]]
    couldn't find "librnscreens.so"

Hmm puzzling. Searching that library's tracker, I don't see any reports that look like a possible match.

It seems like librnscreens.so isn't winding up in the APK. Could very well be an incompatibility with older RN, as you suggest — the library could be relying on RN to get libraries from one place to another at build time, and RN could have changed how that works in such a way that something the library is now doing works with current RN but not older RN.

Anyway, makes sense not to try to debug it further.

This all looks good — merging.