search

zulip / zulip-mobile

Zulip mobile apps for Android and iOS.
https://zulip.com/apps/
Apache License 2.0
1.3k stars 656 forks source link

ui: Condition UI-string "channel" terminology on >=255, not >255 #5864

Closed chrisbobbe closed 7 months ago

chrisbobbe commented 7 months ago

Oops; this was missed because I didn't do end-to-end testing before we merged #5830.

gnprice commented 7 months ago

Thanks! Looks good; merging.

I also did some greps for other places where we compare a feature level, and I think we have them all the right way around.

In particular non-strict inequalities are now all "current feature level >= threshold", and strict inequalities are all "<", from reading the output of:

$ git grep 'eatureLevel.*(?<!=)[><]=' 
$ git grep 'eatureLevel.*(?<!=)[><](?!=)'

and for good measure:


$ git grep '(?<!=)[><]=.*eatureLevel' 
$ git grep '(?<!=)[><](?!=).*eatureLevel'