zulip / zulip-mobile

Zulip mobile apps for Android and iOS.
https://zulip.com/apps/
Apache License 2.0
1.3k stars 655 forks source link

Support new settings for restricting direct messages #5870

Closed alya closed 4 months ago

alya commented 5 months ago

We will need to support restricted permissions for sending direct messages as described in https://github.com/zulip/zulip/issues/24467. At a minimum, the mobile app should give a reasonable error when a user tries to send a message that they are not allowed to send.

(TBD whether this is a goal for 9.0.)

gnprice commented 4 months ago

At a minimum, the mobile app should give a reasonable error when a user tries to send a message that they are not allowed to send.

Doing the best possible version of this UX approach (like, an error modal that appears synchronously after they hit the send button) might require more refactoring than we want to do for the legacy app, because currently our message sending happens from an "outbox" system that works at arm's length from the compose box.

For a solution for this issue, we'll want to keep simple the changes we make. So it'll be enough if we have the error message appear asynchronously, for example as a toast, when the outbox system eventually hits it.

chrisbobbe commented 4 months ago

topic-based permissions for sending messages as described in https://github.com/zulip/zulip/issues/24467

That issue is about DMs; I don't find anything on the page about topics. Is this the right issue link?

gnprice commented 4 months ago

That server issue looks like it's making active progress, and it also matches this issue's title. So I think that is the one that's intended, and the mention of "topic-based permissions" in the description is a thinko for some other issue that presumably isn't an immediate priority. @alya, is that the right guess?

alya commented 4 months ago

Oh, sorry, that must be a copy-paste issue. Topic-based permissions are https://github.com/zulip/zulip/issues/19434.

alya commented 4 months ago

Updated the issue description.