search

zulip / zulip-mobile

Zulip mobile apps for Android and iOS.
https://zulip.com/apps/
Apache License 2.0
1.29k stars 650 forks source link

Check / fix table border color in dark mode #5871

Open alya opened 5 months ago

alya commented 5 months ago

As a follow-up to https://github.com/zulip/zulip/issues/29856, we should see if it's worth tweaking the table border color in dark theme in the mobile app.

gnprice commented 5 months ago

Implementation notes:

The first step here is to see if the issue reproduces in mobile. If tables in dark mode already look fine and don't have this issue, then we're done.

If the issue does reproduce, then we should be able to fix it by just copying whatever CSS change is made to fix it in web.

alya commented 4 months ago

The webapp issue has been resolved in https://github.com/zulip/zulip/pull/29859.

gnprice commented 4 months ago

Cool, thanks for the update.

It looks like the key change was in this commit: https://github.com/zulip/zulip/pull/29859/commits/8a9fb047c3013d44749cddfe45a912c266e4e6dd and changed the border color from hsl(0deg 0% 0% / 20%) to hsl(0deg 0% 100% / 20%).

It kind of sounds like this might have been a regression caused in the first place by some other changes — it looks like what happened is that some CSS that was meant for a different part of the UI was too broad and consequently applied also to tables in Markdown content. So that suggests the issue might not exist in mobile. We'll find out as the first step in this issue, as mentioned above.

alya commented 4 months ago

I'm not sure this is a priority for the legacy app? In any case, removing the release goal label, as it's not specifically timely for 9.0.

gnprice commented 3 months ago

Yeah — I think as long as this isn't something we feel we're likely to highlight in the 9.0 announcement (and I suspect it isn't), it isn't a priority for the legacy app.