search

zulip / zulip-mobile

Zulip mobile apps for Android and iOS.
https://zulip.com/apps/
Apache License 2.0
1.3k stars 655 forks source link

build(deps): bump serve-static from 1.15.0 to 1.16.2 #5887

Closed dependabot[bot] closed 2 months ago

dependabot[bot] commented 2 months ago

Bumps serve-static from 1.15.0 to 1.16.2.

Release notes

Sourced from serve-static's releases.

1.16.0

What's Changed

New Contributors

Full Changelog: https://github.com/expressjs/serve-static/compare/v1.15.0...1.16.0

Changelog

Sourced from serve-static's changelog.

1.16.2 / 2024-09-11

  • deps: encodeurl@~2.0.0

1.16.1 / 2024-09-11

  • deps: send@0.19.0

1.16.0 / 2024-09-10

  • Remove link renderization in html while redirecting
Commits
Maintainer changes

This version was pushed to npm by wesleytodd, a new releaser for serve-static since your current version.


Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/zulip/zulip-mobile/network/alerts).
gnprice commented 2 months ago

This issue probably doesn't affect us. It's in a Web server framework, which we use only within some dev dependencies:

$ yarn why serve-static
yarn why v1.22.19
[1/4] Why do we have the module "serve-static"...?
[…]
=> Found "serve-static@1.15.0"
info Reasons this module exists
   - "react-native#@react-native-community#cli" depends on it
   - Hoisted from "react-native#@react-native-community#cli#serve-static"
   - Hoisted from "react-native#@react-native-community#cli#@react-native-community#cli-debugger-ui#serve-static"
   - Hoisted from "react-native#@react-native-community#cli#@react-native-community#cli-server-api#serve-static"
[…]

Apparently the vulnerability shows up if an attacker makes a request to the server, and the server code calls response.redirect.

I'm not certain it can't affect us, though: possibly @react-native-community/cli-debugger-ui via serve-static does expose such a redirect, so that if someone's running that when developing our codebase possibly it could be accessible to an attacker on another machine, or something.

So we'll take the upgrade.

The diff is a little messy as I commented above. The mess is harmless but would probably cause similar mess in reverse the next time we do a yarn upgrade or yarn add etc. operation ourselves; possibly even just yarn / yarn install (which is routine in development). So I'll take a few extra minutes and do the upgrade myself.

gnprice commented 2 months ago

So I'll take a few extra minutes and do the upgrade myself.

5889. Closing this PR in favor of that one.

dependabot[bot] commented 2 months ago

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

gnprice commented 2 months ago

(Apart from the upgrade itself which is of possible but doubtful relevance, this PR came in handy because it turned up #5888! That's something we'll definitely want to fix.)

gnprice commented 2 months ago

I'm not certain it can't affect us, though: possibly […]

Also to be explicit about why I gave this more attention than #5874: that one was a DoS, but this one (CVE-2024-43800) is RCE if it can be triggered, which is a much worse consequence.