zulip / zulip-mobile

Zulip mobile apps for Android and iOS.
https://zulip.com/apps/
Apache License 2.0
1.3k stars 655 forks source link

android: Force me.relex:photodraweeview at v2.1.0 #5891

Closed chrisbobbe closed 2 months ago

chrisbobbe commented 2 months ago

The retired repo "jcenter" has been saying for years that it'll go away, and that seems to have happened. Take this dependency at a later version, which is available from Maven Central.

Fixes: #5888

chrisbobbe commented 2 months ago

Tested on the office Android device (Samsung Galaxy S9 running Android 9). Not sure if this needs testing on a newer Android.

gnprice commented 2 months ago

Thanks! Looks good — merging.

I think this shouldn't interact much with the Android version.

I did try running it… but found our shell.nix has bitrotted somewhat so that nix-shell --run tools/android (and indeed nix-shell --run adb) doesn't work on the NixOS version I now have on my office desktop. So I won't spend time trying to resolve that right now, for this legacy codebase. (My home desktop still works fine, when I'm at home.)