search

zulip / zulip-mobile

Zulip mobile apps for Android and iOS.
https://zulip.com/apps/
Apache License 2.0
1.3k stars 655 forks source link

Button Label Inconsistent with naming of Channels and Streams #5898

Open Joshy-R opened 1 month ago

Joshy-R commented 1 month ago

On Mobile Devices with large Screens, the labels of the buttons on the bottom show their label. The label for the second button shows 'Streams', although for the new Zulip version, this should be renamed to 'Channels'. Other labels throughout the app show the correct text (e.g. the title of the channels section has the text 'Channels').

This issue may not be relevant for the mobile app, as the new app is already in beta. Feel free to close this issue if this app version is soon EOL.

gnprice commented 1 month ago

Thanks for the report.

It looks like the underlying issue here is that those tab labels aren't marked for translation. If they were, then the general mechanism we applied (in #5830) for the stream/channel rename would have caught the string "Streams" and caused it to say "Channels" when you're using a recent server, just like in other places in the app.

I think this is indeed an issue we won't fix within this legacy app. I'll leave it open because it is a genuine issue in this app; but it'll be one of the issues we leave unfixed when we launch the new app and archive this app's issue tracker.

mayankdhangar2408 commented 4 days ago

hey @gnprice @Joshy-R , can u assign this issue to me, i think i can work on this issue and please explain it to me in brief

gnprice commented 2 days ago

@mayankdhangar2408 See my reply to another of your comments: https://github.com/zulip/zulip-mobile/issues/5885#issuecomment-2487410893