search

zulip / zulip-redmine-plugin

Redmine plugin for Zulip notifications on issue tracker changes
Apache License 2.0
12 stars 17 forks source link

Improve settings #11

Closed batistadasilva closed 5 years ago

batistadasilva commented 5 years ago

Hello, this is an improvement submission

I have just setup the plugin on my Redmine instance following the instructions guide and I found a bit confusing to set server's hostname/path without any protocol on one field, then server's port on a separate field.

It would be more straight forward for Redmine administrators to set only one field with the full URL https://yourZulipDomain.zulipchat.com/api.

The online documentation should be updated.

This pull request contains all commits of #8 #9 #10 feel free to merge only this one or each one separately.

Thank you very much

timabbott commented 5 years ago

Also do you think these changes close any of the open issues?

batistadasilva commented 5 years ago

This definitely closes #6

I don't totally understand other issues' problems, but they can retry with this new version

Also, after merging #8 please wait for me to rebase this branch before merging it. This way everything stays clean :wink:

timabbott commented 5 years ago

Since this also changes what we need to document, can you also submit a pull request to http://github.com/zulip/zulip/ editing templates/zerver/integrations/redmine.md with the corresponding changes? Thanks!

batistadasilva commented 5 years ago

do you think this could be the version 1.0?

timabbott commented 5 years ago

I'd certainly be fine with that.