Closed ogg1e closed 8 years ago
I committed the change to switch the API based on the URL. I tested it as best as I could on a local install, but not on zulip.com.
I also have signed the CLA
Thanks @ogg1e ! A few small tweaks:
env GIT_AUTHOR_NAME="Gary Ogden" GIT_AUTHOR_EMAIL=<email> git commit --amend --reset-author
zulip_api_basename
to zulip_api_endpoint
if it's going to include the /messages
part? Alternatively you could leave it the funciton as zulip_api_basename
and concatenate strings in the req = Net::HTTP::Post.new(zulip_api_basename())
line.I had some issues with the squash, but I think I've got it right now.
Thanks @ogg1e ! This looks great except that this seems to have lost the commit author fix somewhere in the rebase; can you fix that?
There, I think it's all correct now. Sorry about that.
Merged, thanks for fixing this @ogg1e !!
Thanks for contributing this @ogg1e !
I posted one comment, but otherwise this lgtm, assuming you've tested this and have signed the Dropbox CLA: https://opensource.dropbox.com/cla/