search

zulip / zulip-redmine-plugin

Redmine plugin for Zulip notifications on issue tracker changes
Apache License 2.0
12 stars 17 forks source link

Fix plugin settings #8

Closed batistadasilva closed 5 years ago

batistadasilva commented 5 years ago

Hello everybody,

I have experienced some issues trying to setup the plugin on my Redmine v3.4 instance, similar to https://github.com/zulip/zulip-redmine-plugin/issues/6 & https://github.com/zulip/zulip-redmine-plugin/issues/7

These changes fix the problems with plugin settings

timabbott commented 5 years ago

Thanks for cleaning up this plugin @felipebatista! It would be great if you can fix the merge conflicts with your now-merged PRs as well as address the comment above (possibly in the form of just adding a code comment explaining where 5 comes from).

batistadasilva commented 5 years ago

You are very welcome @timabbott! I have just pushed some changes in this bit of code in order to make it more self-explanatory, what do you think?

timabbott commented 5 years ago

Yes, this is much more readable, thanks @felipebatista!

Merged.