Improve user feedback for compose box's content-length limits

zee-bit commented 3 years ago

After the recent merge of #996, ZT added content-length restrictions for the compose box, which is fine as a v1, but there are potential scope for improvement particularly in the UI.

[ ] A potential v1.5 is to strip leading whitespace, as we do for search, since those are already stripped by the server, and our restriction might block the following text from getting entered in the compose box.
[ ] The next iteration would be to somehow indicate(and not restrict), that input beyond a particular length will probably get cropped out after sending. There are several ways we could achieve this:
- Display a countdown of the characters left before reaching limit, in the footer. Or, to save the footer for other more important notifications, display the countdown only after a certain threshold is met.
- Varying the color of the text that overflows, to maybe Red, and limit cycling to other boxes. Showing a "box to fill in" with a colored background would also illustrate how much space there was left in the first place.

Both of the sub-points in the second point could work as a v2. However, I am more inclined towards the latter as it opens the path for a new UI approach, i.e. Colored overflowing text. Also, the footer would be left for critical notifications, like Autocomplete suggestion and edit time-limit warnings. One more thing to mention is that the content-length limits we have here could be relevant to #905 and also things like maximum left/right-panel width.

Relevant discussion: #zulip terminal> restrict topic name length.

Dishti-Oberai commented 2 years ago

Hi, I am interested to work on this issue. @zulipbot claim

zulipbot commented 2 years ago

Hello @Dishti-Oberai, it looks like you've currently claimed 1 issue in this repository. We encourage new contributors to focus their efforts on at most 1 issue at a time, so please complete your work on your other claimed issues before trying to claim this issue again.

We look forward to your valuable contributions!

zulipbot commented 2 years ago

Hello @Dishti-Oberai, you have been unassigned from this issue because you have not updated this issue or any referenced pull requests for over 14 days.

You can reclaim this issue or claim any other issue by commenting @zulipbot claim on that issue.

Thanks for your contributions, and hope to see you again soon!

Dishti-Oberai commented 2 years ago

Hi, I am still working on it

4rjunc commented 8 months ago

@zulipbot claim

zulipbot commented 8 months ago

Hello @H4K3R13!

Thanks for your interest in Zulip! You have attempted to claim an issue without the label "help wanted". You can only claim and submit pull requests for issues with the help wanted label.

If this is your first time here, we recommend reading our guide for new contributors before getting started.

zulip / zulip-terminal

Improve user feedback for compose box's content-length limits #1010